Skip to content

chore: Improper calls to Meteor.userId() in React components #36775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ggazzo merged 1 commit into from
Aug 22, 2025
Merged

chore: Improper calls to Meteor.userId() in React components #36775

ggazzo merged 1 commit into from
Aug 22, 2025

Conversation

@tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Aug 22, 2025 •
edited by atlassian bot
Loading

Proposed changes (including videos or screenshots)

It replaces calls to Meteor.userId() in React components instead of relying on useUserId().

Issue(s)

ARCH-1786

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Aug 22, 2025 •
edited
Loading

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.11.0, but it targets 7.10.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Aug 22, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2f4803a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Aug 22, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.10%. Comparing base (34f05ee) to head (2f4803a).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #36775   +/-   ##
========================================
  Coverage    66.09%   66.10%           
========================================
  Files         3298     3298           
  Lines       110881   110881           
  Branches     21031    21032    +1     
========================================
+ Hits         73290    73295    +5     
+ Misses       34915    34912    -3     
+ Partials      2676     2674    -2
Flag Coverage Δ
e2e 57.31% <100.00%> (+0.01%) ⬆️
unit 71.41% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tassoevan tassoevan force-pushed the chore/improper-meteor-user-id-calls branch from 4fdd67e to 2f4803a Compare August 22, 2025 19:22
@tassoevan tassoevan added this to the 7.11.0 milestone Aug 22, 2025
@tassoevan tassoevan marked this pull request as ready for review August 22, 2025 21:20
@tassoevan tassoevan requested a review from a team as a code owner August 22, 2025 21:20
dougfabris
dougfabris approved these changes Aug 22, 2025
View reviewed changes
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Aug 22, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 22, 2025
@ggazzo ggazzo merged commit 776af0a into develop Aug 22, 2025
86 of 88 checks passed
@ggazzo ggazzo deleted the chore/improper-meteor-user-id-calls branch August 22, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggazzo ggazzo ggazzo approved these changes

@dougfabris dougfabris dougfabris approved these changes

Assignees

No one assigned

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Milestone

7.11.0

Development

Successfully merging this pull request may close these issues.

4 participants

@tassoevan @ggazzo @dougfabris